-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler flag to set bytecode size limit #10981
Comments
I wonder if it might be better to offload this check to frameworks after all. In Hardhat, Truffle and Brownie (and likely most others) you define a list of networks, each with specific settings like gas limit. Hardhat's network settings even have Maybe just removing the warning and coordinating with frameworks to add a check there (with a good default) would be best? |
To be fair the warning was encouraged by hardhat:
Perhaps @alcuadrado changed his mind since? However @cameel, on the other hand I think that frameworks which have a setting like |
True. They could. @gorgos, are using the compiler directly or via a framework?
Yeah, that's what I actually referring to. It was encouraged back then but maybe it would be better to talk it over again given that we're now discovering that we don't really have enough info in the compiler to decide if it's warranted or not (at least with adding extra flags for the user to provide that info). |
@cameel Via framework, both Truffle and Hardhat. |
Looks like we'll probably address this problem in a different way: #11508. |
This issue has been marked as stale due to inactivity for the last 90 days. |
Hi everyone! This issue has been automatically closed due to inactivity. |
From #2691 (comment)
Custom chains may allow deploying contracts bigger than 24 kB but the limit is currently hard-coded in the compiler and exceeding it triggers a warning that can't be suppressed. In #2691 it was proposed that the solution might be to introduce a compiler flag that allows the user to change the limit to an arbitrary value and avoid the warning.
The text was updated successfully, but these errors were encountered: