Implement the binary search dispatch for the IR codegen

[hrkrshnn]

The binary search for the function dispatch seems to be only implemented in the legacy codegen.

Context:

solidity/libsolidity/codegen/ContractCompiler.cpp

Line 325 in da50176

void ContractCompiler::appendInternalSelector(

Implement the same for the IR based codegen.

[cameel]

Related: #12650.

[chriseth]

I would prefer binary search (or constant-time search) to be implemented for all switch statements instead of writing custom code for the external dispatch. This has the advantage that it 1) can use jumps because it will be in the evm code gen and 2) it automatically applies to the external and the internal dispatch.

[frangio]

I would prefer binary search (or constant-time search) to be implemented for all switch statements instead of writing custom code for the external dispatch.

I'm not sure this is possible for constant-time search without a special case for external dispatch. The last developments in #12650 make use of the fact that selectors are already random, so re-hashing is not needed. This will not be true of an arbitrary switch statement.

[chriseth]

While that is true, we can still try. Since the case values are compile-time constants, we will know if it failed or not.

[github-actions]

This issue has been marked as stale due to inactivity for the last 90 days.
It will be automatically closed in 7 days.

[github-actions]

Hi everyone! This issue has been automatically closed due to inactivity.
If you think this issue is still relevant in the latest Solidity version and you have something to contribute, feel free to reopen.
However, unless the issue is a concrete proposal that can be implemented, we recommend starting a language discussion on the forum instead.