Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ETH1_ADDRESS_WITHDRAWAL_PREFIX withdrawal credentials (0x01) #188

Open
hwwhww opened this issue Mar 16, 2021 · 0 comments · Fixed by #195
Open

Support ETH1_ADDRESS_WITHDRAWAL_PREFIX withdrawal credentials (0x01) #188

hwwhww opened this issue Mar 16, 2021 · 0 comments · Fixed by #195
Labels
enhancement New feature or request

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Mar 16, 2021

Issue

Eth2 spec v1.0.1 enables a new withdrawal credential type that is a 20-byte eth1 address. (See ethereum/consensus-specs#2149). Currently, deposit-cli doesn't support it.

How to fix it

  1. Enable user to type their Eth1 address
  2. Check the given Eth1 address format
  3. Set withdrawal credential with Eth1 withdrawal credentials (0x01) consensus-specs#2149 rule
  4. Generate deposit data properly
@hwwhww hwwhww added the enhancement New feature or request label Mar 16, 2021
@hwwhww hwwhww mentioned this issue Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Eth1 address withdrawal support ethereum/staking-deposit-cli
1 participant
@hwwhww