Issue1560 #1594
Merged
Issue1560 #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
reviewed
Mar 4, 2020
There was a problem hiding this comment.
Thanks @realjohnward! This is looking good to me! Just added a few comments, mostly around testing.
@pipermerriam do you have any feedback?
|
No problem @kclowes . Thank you for reviewing this and making adjustments! |
kclowes
force-pushed
the
issue1560
branch
2 times, most recently
from
2e11b33 to
4588481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The hasattr method wasn't working for the ContractEvent object (wasn't returning True or False)
AttributeError wasn't being raised in the ContractEvent's getattr method.
Related to Issue #1560
How was it fixed?
Added hasattr overloader to ContractEvent class which returns False if an AttributeError is raised during the getattr call.
Added exception class called ABIEventFunctionNotFound, which inherits from AttributeError and MismatchedABI.
Todo:
Cute Animal Picture