Upgrade eth-tester to v0.4.0-beta.2 #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
changed the title
carver
reviewed
May 1, 2020
carver
approved these changes
May 6, 2020
kclowes
force-pushed
the
eth-tester-040b2
branch
2 times, most recently
from
d01c8d1 to
e29e7b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
With pip's lack of dependency resolution, we had an incompatible eth-keys version that was raising errors in a fresh
pip install -e .[dev]install, so it had to be pinned at"eth-keys>=0.2.1,<0.3". This is fixed in the v0.4.0-beta2 release of eth-tester.Related to issue #1622
How was it fixed?
Upgraded eth-tester
Todo:
Cute Animal Picture