Adding Python3.9 support #1774
Adding Python3.9 support #1774
Conversation
|
Hi, trying here to make my first contribution to web3.py but can't really figure out what is happening at Circle CI checks. Any tip on what I'm able to do from here? |
|
Awesome, thanks @gabriellm1! What happens if you remove the |
|
That doesn't appear to change anything |
|
hmm, bummer. I can take a look. Maybe there's a dependency or two that needs updating or something 🤔 |
|
cc @davesque looks like you're the man behind the curtain for the Looks like maybe your library needs a new build published to support python 3.9? |
|
Should I check if there is any other dependencies which doesn't support python3.9 yet? And I also commented 'typing-extensions' dependencie since there was a comment asking to do so after python3.8, have I done right? Last, if it's not a problem would u guys please tag this PR with hacktoberfest-accepted ? |
|
I think that before this is mergable we're going to need to officially get 3.9 supported up the dependency chain. That means this sort of update is going to need to be applied to at least all of the libraries we maintain in the dependency chain. |
|
Sorry @gabriellm1, I was hoping this would be a quick update! Thanks for the work! |
|
No problem guys, happy to help. Feel free to contact me if there is any update on this. |
|
|
What was wrong?
web3.py doesn't support python3.9
Related to Issue #1769
How was it fixed?
Followed PR #1471 template that added support to python3.8
Todo:
Cute Animal Picture