Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eth-account to 0.5.6 and update docs #2157

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Sep 23, 2021

What was wrong?

  • Needed to update eth-account with newly released version 0.5.6

How was it fixed?

  • eth-account updated to 0.5.6
  • docs updated to reflect that transaction type is no longer necessary to sign transactions using web3.eth.account.sign_transaction due to recent eth-account updates
  • updated some more docs dealing with sign_transaction to use new dynamic fee transaction params over gasPrice

Todo:

Cute Animal Picture

IMG_20210527_082744

@fselmo fselmo force-pushed the eth-account-sign-txn-updates branch 4 times, most recently from d3aa867 to 7b0ff15 Compare September 23, 2021 18:08
@fselmo fselmo requested a review from kclowes September 24, 2021 01:57
@fselmo fselmo force-pushed the eth-account-sign-txn-updates branch from 7b0ff15 to f25d116 Compare September 24, 2021 02:00
* eth-account updated to 0.5.6
* docs updated to reflect that transaction type is no longer necessary to sign transactions using web3.eth.account.sign_transaction due to recent eth-account updates
* updated some more docs dealing with sign_transaction to use new dynamic fee transaction params over gasPrice
@fselmo fselmo force-pushed the eth-account-sign-txn-updates branch from f25d116 to 514448d Compare September 24, 2021 02:09
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@fselmo fselmo merged commit 0abf14a into ethereum:master Sep 24, 2021
@fselmo fselmo deleted the eth-account-sign-txn-updates branch September 24, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants