-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add black to ethpm #2345
Add black to ethpm #2345
Conversation
How about using pre-commit to automate formatting stuff? |
@Harmouch101 That looks like a good option, but I'm going to hold off for now. If we decide running black is too clunky then I may pull it in. Thanks for the suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I was originally thinking we could set the line-length to This change would do that within [tool.black]
line-length = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Excited for this addition. I just left one comment to think about before we start changing everything to black across the code base. But maybe we should just leave it all default black settings since that's kind of the point 😅 .
+1 for default line length 88 |
Okay, I'll leave line length at 88. Thanks! |
What was wrong?
Black is finally stable, so pulling it in. One module at a time.
Related to Issue #1416
How was it fixed?
added the Black dependency, let it make any fixes.
Todo:
Cute Animal Picture