Validate forward resolution for reverse resolution by default #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As outlined in the warning in the ENS docs, for the reverse resolution of a name for an address to be accurate, the forward resolution address must also match. Source at the time of this commit is here: https://docs.ens.domains/dapp-developer-guide/resolving-names#reverse-resolution.
fselmo
force-pushed
the
ens-backwards-resolution-strict-check-by-default
branch
from
ff5abb5 to
1197256
Compare
|
@fselmo When can we get this released? We're currently using 5.24.0 so I'll need to upgrade |
Hey @Slokh, thanks for the patience. We're getting one more PR approved that's important for us pre-release but it should be just around the corner. The |
|
Thanks for the update @fselmo |
|
@Slokh this feature (with the flag) just got released in web3 v5.29.0! |
|
Thanks both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
As outlined in the warning in the ENS docs, for the reverse resolution of a name for an address to be accurate, the forward resolution address must also match. Source at the time of this commit is here: https://docs.ens.domains/dapp-developer-guide/resolving-names#reverse-resolution.
Related to Issue #2417, #2419 (
v5implementation of this same concept. Use this as default logic forv6)How was it fixed?
Todo:
Cute Animal Picture