Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black to web3/middleware #2521

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jun 16, 2022

What was wrong?

Adds black linting to web3/middleware files

Related to Issue #2519

How was it fixed?

Added correct directory to black command in tox.ini and ran it locally.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more! lgtm 👍

@kclowes kclowes force-pushed the black-middleware branch from 9124a95 to da839f6 Compare June 17, 2022 20:41
@kclowes
Copy link
Collaborator Author

kclowes commented Jun 17, 2022

I realized that when I'm squashing these PRs into master, the SHA changes, even if I only do a Squash and merge. I started tracking the correct SHAs from master in #2524, so will leave .git-blame-ignore-revs unchanged in these individual PRs. Once black has been added everywhere and merged into master, I'll merge in #2524. Let me know if that doesn't make sense!

@kclowes kclowes merged commit ca1dbbd into ethereum:master Jun 17, 2022
@kclowes kclowes deleted the black-middleware branch June 17, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants