Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Flake8 Check to 88 Characters #2559

Merged
merged 7 commits into from
Jul 7, 2022
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jul 7, 2022

What was wrong?

We want to be consistent with black defaults, so decreased the line limit down to 88 characters.

Closes #2519 🎉

How was it fixed?

black doesn't touch strings, so I went through and moved stuff around. I think this is the last PR 🤞

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the flake8-88-chars branch from 6ae2af0 to b81c12d Compare July 7, 2022 18:54
@kclowes kclowes marked this pull request as ready for review July 7, 2022 19:59
@kclowes kclowes requested review from fselmo and pacrob July 7, 2022 19:59
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as soon as tests pass! Very happy to get this in! 🐈‍⬛

@kclowes kclowes changed the title Flake8 88 chars Limit Flake8 Check to 88 Characters Jul 7, 2022
@kclowes kclowes merged commit cdc69f0 into ethereum:master Jul 7, 2022
@kclowes kclowes deleted the flake8-88-chars branch July 7, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Black
2 participants