Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eth-account to 0.5.9+ #2606

Closed
kclowes opened this issue Aug 11, 2022 · 2 comments
Closed

Bump eth-account to 0.5.9+ #2606

kclowes opened this issue Aug 11, 2022 · 2 comments
Assignees
@kclowes

Comments

@kclowes
Copy link
Collaborator

kclowes commented Aug 11, 2022

v5+

What was wrong?

eth-account 0.5.9 was released. It has a fix for a DOS-able regex pattern. See ethereum/eth-account#178

How can it be fixed?

Change the requirement in setup.py to be eth-account>=0.5.9,<0.6.0, and make sure web3.py can still be installed in a fresh env.
@kclowes kclowes self-assigned this Aug 11, 2022
@kclowes kclowes mentioned this issue Aug 11, 2022
Merged
1 task
@fselmo fselmo closed this as completed Aug 16, 2022
@fselmo
Copy link
Collaborator

fselmo commented Aug 16, 2022

oops... still needs v6 PR 👀 -- re-opening

@fselmo fselmo reopened this Aug 16, 2022
@fselmo
Copy link
Collaborator

fselmo commented Oct 7, 2022

closed by #2607 and #2623

@fselmo fselmo closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kclowes kclowes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fselmo @kclowes