Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update beacon api to 2.3.0 #2616

Merged
merged 1 commit into from
Aug 24, 2022
Merged

update beacon api to 2.3.0 #2616

merged 1 commit into from
Aug 24, 2022

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Aug 23, 2022 •
edited
Loading

What was wrong?

Web3.py's Beacon API is lagging behind the latest spec.

How was it fixed?

  • Smol fixes: a v1->v2 bump and testing always-in-range values.
  • These smoke/sanity tests are still not integrated into CI. Separate effort required to first decide how we'd want to introduce a Beacon node into the test infrastructure. Local testing performed with a lighthouse node on the sepolia network, e.g. by running lighthouse b --http --http-port 5051 --network sepolia, then executing the tests.
  • Removed some eth2 references and replaced with consensus layer (cl)
  • Removed the 'experimental' warning.

Todo:

Cute Animal Picture

kclowes
kclowes approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! v2! Like we talked about, we can kick the testing down the road for now.

@wolovim wolovim force-pushed the beacon-updates-2.3.0 branch from 7ae12f1 to 155993a Compare August 24, 2022 19:57
@wolovim wolovim force-pushed the beacon-updates-2.3.0 branch from 155993a to eb1a696 Compare August 24, 2022 20:01
@wolovim wolovim merged commit e5c92f4 into ethereum:master Aug 24, 2022
pacrob pushed a commit to pacrob/web3.py that referenced this pull request Sep 8, 2022
@wolovim
update beacon api to 2.3.0 (ethereum#2616)
16c31cb
pacrob pushed a commit that referenced this pull request Sep 8, 2022
@wolovim
update beacon api to 2.3.0 (#2616)
6158844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolovim @kclowes