Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain private keys and account funding #2722

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Conversation

miohtama
Copy link
Contributor

Some basics about private keys and using ETH as a gas fee. This information is unknown to many new developers.

What was wrong?

People do not know how to use private keys in development.

How was it fixed?

Explain the basics in the documentation.

Cute Animal Picture

((...))         ((...))         ((...))           L...L  
( o o )         ( x x )         ( O O )          < o o >
 \   /           \   /           \   /            \   /
  ^_^  cp97       ^_^  cp97      (`_`)  cp97       ^_^  cp97

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the much-needed improvement / clarification. Just had some minor typos / suggestions. I can make those if you're good with it and add a doc newsfragment... lmk 👀

docs/web3.eth.account.rst Outdated Show resolved Hide resolved
docs/web3.eth.account.rst Outdated Show resolved Hide resolved
docs/web3.eth.account.rst Outdated Show resolved Hide resolved
docs/web3.eth.account.rst Outdated Show resolved Hide resolved
@miohtama
Copy link
Contributor Author

miohtama commented Jan 3, 2023

@fselmo resolved spell check - thank you!

fselmo pushed a commit to miohtama/web3.py that referenced this pull request Jan 3, 2023
@fselmo
Copy link
Collaborator

fselmo commented Jan 3, 2023

rebased and consolidated commits 👍🏼

- Some basics about private keys and using ETH as a gas fee. This information is unknown to many new developers.
- Newsfragment.
@fselmo fselmo merged commit 3cec341 into ethereum:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants