Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parity and trinity refs in IPCProvider docs #2971

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Jun 2, 2023

What was wrong?

IPCProvider docs still referenced ipc paths for Parity and Trinity
get_dev_ipc_path still had the Trinity default for Windows

How was it fixed?

Removed references to deprecated providers.

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the cleanup-ipc-provider-docs branch from 852574c to 9eb09cb Compare June 2, 2023 18:14
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⛵

@pacrob pacrob merged commit 955e10c into ethereum:main Jun 2, 2023
@pacrob pacrob deleted the cleanup-ipc-provider-docs branch June 2, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants