Panic error support #2986
Merged
Panic error support #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
commented
Jun 7, 2023
fselmo
commented
Jun 7, 2023
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Jun 7, 2023
fselmo
force-pushed
the
panic-error-support
branch
from
8951d47 to
44d0895
Compare
|
This should be ready for review now |
kclowes
approved these changes
Jun 8, 2023
| @@ -698,95 +691,6 @@ def apply_list_to_array_formatter(formatter: Any) -> Callable[..., Any]: | |||
| STANDARD_NORMALIZERS, RPC_ABIS | |||
| ) | |||
|
|
|||
| # the first 4 bytes of keccak hash for: | |||
There was a problem hiding this comment.
So much better. Nice cleanup!
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Jun 8, 2023
fselmo
force-pushed
the
panic-error-support
branch
from
44d0895 to
52673dd
Compare
- Refactor contract error handling to its own file for better readability. Some re-structuring of the ``raise_contract_logic_error_on_revert()`` method could probably also be done but for now just move this over to its own spot in the ``_utils``.
- Add support for Solidity Panic errors and provide clear messaging for each defined error code - Create and compile a Solidity contract for testing, PanicErrorsContract.sol - Add core tests for use with EthereumTesterProvider / eth-tester + py-evm
- The test fixture had not been updated to 1.11.5 thought he name stated so. This commit adds the ``shanghaiBlock`` as well as the last few glacier blocks which only changed the difficulty bomb timing so shouldn't have made much of a difference on the API. - Regeneration of the fixture is now guaranteed to be using 1.11.6 Related changes to ethereum#2985 - Add integration tests for Solidity Panic errors and, with the regeneration of the fixture above, make sure they work against Geth.
fselmo
force-pushed
the
panic-error-support
branch
from
52673dd to
dbc58db
Compare
reedsa
reviewed
Jun 8, 2023
reedsa
approved these changes
Jun 8, 2023
| def __init__( | ||
| self, | ||
| message: Optional[str] = None, | ||
| data: Optional[Union[str, Dict[str, str]]] = None, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #2985
How was it fixed?
_utilsfile for better code readabilityPanicerrorsEthereumTesterProviderand integration tests testing againstgethshanghaiTime(also added the glacier blocks to the config though those are less important since it was just difficulty bomb timing).** It turns out we were a few geth versions behind though the filename was misleading. This PR regenerates the test fixture with
1.11.6and bumps the CI's py-geth version and geth version as well.Todo:
Cute Animal Picture