Fix max_priority_fee when eth_maxPriorityFeePerGas is unavailable #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardhat sends {'code': -32601, 'message': 'Method eth_maxPriorityFeePerGas not found', 'data': {'message': 'Method eth_maxPriorityFeePerGas not found'}} which raises MethodUnavailable instead of ValueError
|
Thanks for the PR! I added a test and will add a newsfragment shortly. |
reedsa
reviewed
Jun 27, 2023
kclowes
changed the title
|
Thanks @sanekto! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardhat anwers
{'code': -32601, 'message': 'Method eth_maxPriorityFeePerGas not found', 'data': {'message': 'Method eth_maxPriorityFeePerGas not found'}}which raisesMethodUnavailableinstead ofValueError.It is not clear to me if the answer of other nodes causes ValueError or now only MethodUnavailable (so to replace the exception).
What was wrong?
Explained above. I did not open an issue because I feel that in this case it is easier to explain the issue showing a possible fix. Sorry if this mess things, also to not provide tests.
How was it fixed?
Todo: