Add ens name-to-address support for eth_subscribe method #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Jul 26, 2023
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Aug 1, 2023
fselmo
force-pushed
the
eth_subscribe-name-to-address-support
branch
from
d8294a3 to
d235de2
Compare
wolovim
approved these changes
Aug 2, 2023
- Add special case for eth_subscribe logs arg for ENS name-to-address middleware
fselmo
force-pushed
the
eth_subscribe-name-to-address-support
branch
from
d235de2 to
23a3f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth_subscriberequest for "logs" takes an optional dict arg that can include an address param. This case isn't supported by the usual flow for the rpc-abi request formatters because those parse either sequence args to methods or dict args, but not dict args within list sequences... e.g.("logs", {"address": "0x...", "topics": ["0x...", "0x..."]})How was it fixed?
Note: It isn't ideal to not add a test here. However, we don't yet have a good test flow for
eth_subscribe. Since this is still in beta, via WebsocketProviderV2, I suggest to test this locally and we can work oneth_subscribetests separately.Todo:
Cute Animal Picture
MidJourney's interpretation of "a websocket as an animal":