Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS .eth Registrar Integration #379

Closed
carver opened this issue Oct 24, 2017 · 4 comments
Closed

ENS .eth Registrar Integration #379

carver opened this issue Oct 24, 2017 · 4 comments
Assignees

Comments

@carver
Copy link
Collaborator

carver commented Oct 24, 2017

Add in the ENS .eth Registrar functionality. #342 only needed the resolver setup and lookup.

Participating in the .eth auctions can be added after the v4 beta launches, without disruption. The main thing that held up this functionality inclusion in #343 was building out a cleaner test suite (with integrated tests, and minimal mock usage).

@carver carver added this to the Version 4 Stable milestone Oct 24, 2017
@carver carver self-assigned this Oct 24, 2017
@carver
Copy link
Collaborator Author

carver commented Jan 30, 2018

Maybe/probably this doesn't need to go into web3. I should probably just wrap up this work I started, and leave it as a separate library: https://github.com/carver/ensauction.py

(a fork of ens.py, that works with the latest web3, and only provides the auction/registrar utilities)

@pipermerriam
Copy link
Member

Not sure if this is useful, but you could theoretically leverage some of the python3 async to deal with the waiting for transactions part.

@carver carver removed this from the Version 4 Stable milestone Mar 1, 2018
@wolovim
Copy link
Member

wolovim commented Sep 17, 2020

[old issue cleanup]

My gut is that Web3.py probably shouldn't have primitives for leasing ENS names, and that functionality should remain with the ENS app (or be built as needed by dapp devs). Agree/disagree? Is there any other functionality included in "Registrar Integration" that should be considered?

@carver
Copy link
Collaborator Author

carver commented Sep 17, 2020

Yup, agree. At most, maybe it's useful to know if/when a lease on a name ends, because it can affect how trustworthy a name is. (Maybe we ought to reject resolving names where ownership has already expired, for example).

But that's a pretty advanced feature, and belongs far enough down on the priority list that it should just be re-opened as an issue when it's time.

@carver carver closed this as completed Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants