-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENS .eth Registrar Integration #379
Comments
Maybe/probably this doesn't need to go into web3. I should probably just wrap up this work I started, and leave it as a separate library: https://github.com/carver/ensauction.py (a fork of ens.py, that works with the latest web3, and only provides the auction/registrar utilities) |
Not sure if this is useful, but you could theoretically leverage some of the python3 async to deal with the waiting for transactions part. |
[old issue cleanup] My gut is that Web3.py probably shouldn't have primitives for leasing ENS names, and that functionality should remain with the ENS app (or be built as needed by dapp devs). Agree/disagree? Is there any other functionality included in "Registrar Integration" that should be considered? |
Yup, agree. At most, maybe it's useful to know if/when a lease on a name ends, because it can affect how trustworthy a name is. (Maybe we ought to reject resolving names where ownership has already expired, for example). But that's a pretty advanced feature, and belongs far enough down on the priority list that it should just be re-opened as an issue when it's time. |
Add in the ENS .eth Registrar functionality. #342 only needed the resolver setup and lookup.
Participating in the .eth auctions can be added after the v4 beta launches, without disruption. The main thing that held up this functionality inclusion in #343 was building out a cleaner test suite (with integrated tests, and minimal mock usage).
The text was updated successfully, but these errors were encountered: