-
Notifications
You must be signed in to change notification settings - Fork 43
Add support for private networks #22
Comments
I've some reservations towards the chain spec format, that's why I somewhat put that aside. These are mainly:
So: there would be definitely some more discussion necessary if we want to move in this direction. Atm I actually wouldn't want to set a priority here. Maybe some middle ground would be to adopt naming and un-problematic structure as much as possible but e.g. leave accounts and bootstrap nodes separate (people could just copy-and-paste to separate files, which should be acceptable). There is actually some ongoing discussion atm on Gitter about crossclient standards on genesis definition, but I somewhat dropped here since I wasn't so satisfied with the running discussion. |
Yes, no urgency to adopt the full chain spec format. However, I do need to be able to load custom genesis settings into a
with these changes to
If this makes sense, I can create a PR |
Addressed with #24, will close. |
In order to support private networks, we should allow an instance of Common to be created from a chain spec and/or a geth genesis file. Any of the following would be user-friendly ways to construct a Common instance from a spec file:
We could also consider migrating the json definition files in the
chains/
folder to the chain spec format for consistency and future-proofing.The text was updated successfully, but these errors were encountered: