hardware-wallets: remove console.log #1136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricmoo
added
enhancement
ricmoo
added a commit
that referenced
this pull request
Nov 19, 2020
|
Merged in 5.0.21. Thanks! |
ricmoo
added
fixed/complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this software! I'm currently working on a project that is using ethers to deploy a bunch of contracts and using a bash script to read from stdout and then operate on that output. In the
hardware-walletspackage, there is aconsole.login the codepath that I am using which causes additional data to be written to stdout which is breaking my bash script. This PR removes the console.log. It also updates theREADMEto reflect the default value in the codebase.I built the files with
npm buildand also anpm test, all of the tests pass.