Fix redundant provider call when nonce=0 is specified

[nikitaeverywhere]

Hello!

I've noticed a redundant call to providers when nonce = 0 (as a number) is specified explicitly in contract transactions, for example:

await tokenContract.functions.transfer("0x...", "10000000", {
  gasPrice: "1000000000",
  nonce: 0
});

Nonce can be 0 when it's the first transaction from the account. In the previous code,

                    if (transaction.nonce) {
                        noncePromise = Promise.resolve(transaction.nonce)
                    } else if (signer.getTransactionCount) {

It didn't resolve immediately because of if (0) { ... } gives false.

Thanks for your work!

[nikitaeverywhere]

Some tests timeout Timeout of 2000ms exceeded, looks like it's not caused by this PR.

[ricmoo]

Ah! Good catch!

Timeouts are often ok, but depends on the test. If you re-run it, it should work. Usually it’s a sign that Etherscan is under heavier than usual load, but the timeout should be increased for that test case anyways if it is hitting 2s.

[nikitaeverywhere]

If you re-run it

@ricmoo Unfortunately I can't re-run it as I don't have permissions to do so. Would you try please? Or should I also submit PR which increases timeouts? :) 2 seconds is pretty strict I would say by the way.

[ricmoo]

No worries. I’ll check it out when I get home tonight. :)

[nikitaeverywhere]

Thanks man! :)

[ricmoo]

This has been updated in v3.0.29.

Thanks! :)

[nikitaeverywhere]

Great, thanks!