Support blockHash in getLogs (EIP-234)

[epheph]

Simple change to allow blockHash through checkFilter(). The type union isn't strictly necessary, but it is more descriptive.

[ricmoo]

Is this widely supported? I don’t see it in the JSON-RPC specification: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_newfilter

[epheph]

It's for getLogs:
https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getlogs
It wouldn't work as a filter, since it wouldn't change over time

[ricmoo]

Oh! That makes way more sense! :)

Thanks, I had not seen EIP-234. I’ll look into it and get back to this PR this week.

[epheph]

Awesome, thanks! For context, I am working on a project which injects ether.js into https://github.com/ethereumjs/ethereumjs-blockstream , which detects when new blocks come in and manually fetches their logs by blockHash (to avoid a race conditions during re-org where a different block's logs are returned)

[pgebheim]

p.s. the CI is failing just 'cause the dist hash changed and wasn't updated in the test (until we're sure you like this change).

[ricmoo]

Oh yes, no worries. I expect those test cases to fail for normal humans. :)

They are there for me after I make changes so I don’t accidentally publish a package that fails verified deterministic building (could mean the code was maliciously modified by me or a script on my computer, or more likely, that I forgot to run npm run dist). :)

Today I have time to get back to some ethers issues. I’ll check this out this afternoon. :)

[ricmoo]

I have added the changes necessary to get this working for getLogs. I've modified your suggestions a little bit, to prevent the blockHash enabled filter from being used as an EventType, which will require additional work to fully support (which likely won't get in until v5; I'll start adding it to the local v5 branch now).

I've also updated Etherscan to throw if it is attempted, since their blockchain API does not support blockHash.

[ricmoo]

Try out 4.0.24 and let me know if this works for you. There is still some work to be done, and I need to think through what events should look like. I'll be refactoring this a bit in v5.

Thanks! :)

[epheph]

Yep, totally works, thanks!!!

[pgebheim]

Brilliant thanks!

…

On Fri, Feb 8, 2019, 7:50 PM Scott Bigelow ***@***.*** wrote: Yep, totally works, thanks!!! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#412 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFP-uJ-a0TiqCYAhmPmXRmfR5uK0Rifks5vLkWNgaJpZM4af0Mv> .

[ricmoo]

Relevant snippet from v5, looking for some feedback:

export interface EventFilter {
    address?: string;
    topics?: Array<string | Array<string>>;
}

export interface Filter extends EventFilter {
    fromBlock?: BlockTag;
    toBlock?: BlockTag;
}

export interface FilterByBlockHash extends EventFilter {
    blockhash?: string;
}

export type EventType = string | Array<string> | EventFilter;

Thanks! :)