EIP191 signature verification fails on-chain for a signer for different datasets. ecrecover fails to provide same signer address

[aniketpati]

Ethers Version

6

Search Terms

No response

Describe the Problem

Contract:

/* SPDX-License-Identifier: MIT */
pragma solidity ^0.8.0;

contract Sig {
    function validateSignerAndRequest(
        string[] memory _paths,
        string[] memory _hashes,
        address[] memory _recipients,
        address _owner,
        uint8 _v,
        bytes32 _r,
        bytes32 _s
    ) public pure returns (address) {
        bytes32 requestHash = hashData(_paths, _hashes, _recipients, _owner);
        address signer = verifyDigest(requestHash, _v, _r, _s);

        require(signer == address(_owner), "Req::InvalidSignature");

        return signer;
    }

    function hashData(
        string[] memory _paths,
        string[] memory _hashes,
        address[] memory _recipients,
        address _owner
    ) public pure returns (bytes32) {
        bytes32 computedHash = _hashData(_paths[0], _hashes[0], _recipients[0], _owner);

        if (_recipients.length == 1) {
            return computedHash;
        } else {
            for (uint256 i = 1; i < _recipients.length; i++) {
                bytes32 currentHash = _hashData(_paths[i], _hashes[i], _recipients[i], _owner);
                computedHash = keccak256(abi.encodePacked(currentHash, computedHash));
            }
        }

        return computedHash;
    }

    function _hashData(
        string memory _path,
        string memory _hash,
        address _recipient,
        address _owner
    ) internal pure returns (bytes32) {
        return keccak256(abi.encodePacked(_path, _hash, _recipient, _owner));
    }

    function verifyDigest(
        bytes32 _message,
        uint8 _v,
        bytes32 _r,
        bytes32 _s
    ) private pure returns (address signer) {
        bytes32 messageDigest = keccak256(abi.encodePacked("\x19Ethereum Signed Message:\n32", _message));
        return ecrecover(messageDigest, _v, _r, _s);
    }
}

GasLimit calculations script:

const { ethers } = require("ethers");

const provider = new ethers.JsonRpcProvider("https://rpc.chiadochain.net");
// Contract address
const contractAddress = "0x88B4C32618B9C26AE1500C6613Ac8a29b2Dc6e9C";
// Contract ABI
const abi = [
  "function validateSignerAndRequest(string[] memory _paths, string[] memory _hashes, address[] memory _recipients, address _owner, uint8 _v, bytes32 _r, bytes32 _s) public pure returns (address)",
  "function hashData(string[] memory _paths, string[] memory _hashes, address[] memory _recipients, address _owner) public pure returns (bytes32)"
];
// Create an instance of the contract with the correct ABI and provider
const contract = new ethers.Contract(contractAddress, abi, provider);
const wallet = new ethers.Wallet("0x5dae2015153fd64f0a26b34e6fac7e68dabe3289d8d47640a203e68ade1b4138");

// Estimate gas for `validateSignerAndRequest`
async function estimateValidateSignerAndRequest(hashDataParams) {
  try {
    const hash = await contract.hashData(...hashDataParams);
    const bytesPayload = ethers.toBeArray(hash);
    const signed = await wallet.signMessage(bytesPayload);
    const sig = ethers.Signature.from(signed);
    const gasEstimate = await contract.validateSignerAndRequest.estimateGas(...hashDataParams, sig.v, sig.r, sig.s);
    console.log("Gas estimate for validateSignerAndRequest:", gasEstimate.toString());
  } catch (error) {
    console.error("Error estimating gas for validateSignerAndRequest:", error);
  }
}

// Run the estimations
(async () => {
  await estimateValidateSignerAndRequest([
    ["/0x07e9fdf8d5d740aaa287de95ac0e934ee8774b7c5fc40195ea4a9e5ca79816ea"],
    ["0x07e9fdf8d5d740aaa287de95ac0e934ee8774b7c5fc40195ea4a9e5ca79816ea"],
    ["0x387893670d81b988fe9f67f568f8b68a5ed56bec"],
    "0x63e2004354c595d1c26e0dfb5dee412832edb0e2"
  ]);
  await estimateValidateSignerAndRequest([
    ["/0x5cfb85d1b7d2a3f88cb4644c5ee0695cb04ad0ed4db2c1de9c4bce6144066508"],
    ["0x5cfb85d1b7d2a3f88cb4644c5ee0695cb04ad0ed4db2c1de9c4bce6144066508"],
    ["0x387893670d81b988fe9f67f568f8b68a5ed56bec"],
    "0x63e2004354c595d1c26e0dfb5dee412832edb0e2"
  ]);
})();

For the above contract and GasLimit calculations script, the first run is successful while the second run is failing with the GasLimit error: "Error estimating gas for validateSignerAndRequest: Error: execution reverted: "Req::InvalidSignature".

As seen in the above contract and script, the validateSignerAndRequest function is used to validate the signer.

The difference between the two runs is the first 2 parameters of the contract call. For both the cases hash is calculated using the hashData function and then signed using the wallet. The signed message is then passed to the validateSignerAndRequest function along with the hashData parameters and the signature. The validateSignerAndRequest function of the contract then verifies the signer on-chain using the verifyDigest function and returns the signer address.

But, the second run fails with the GasLimit error: "Error estimating gas for validateSignerAndRequest: Error: execution reverted: "Req::InvalidSignature".

How can I fix this issue? What is missing? Since the hash calculation and signing process are the same, signed data is just another hash that should be validated if signed by the valid keys for all instances, what is causing the second run to fail?

Code Snippet

No response

Contract ABI

No response

Errors

Error estimating gas for validateSignerAndRequest: Error: execution reverted: "Req::InvalidSignature" (action="estimateGas", data="0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000155265713a3a496e76616c69645369676e61747572650000000000000000000000", reason="Req::InvalidSignature", transaction={ "data": "0xc1bb36ea00000000000000000000000000000000000000000000000000000000000000e000000000000000000000000000000000000000000000000000000000000001a0000000000000000000000000000000000000000000000000000000000000026000000000000000000000000063e2004354c595d1c26e0dfb5dee412832edb0e2000000000000000000000000000000000000000000000000000000000000001b84a9d4c226d35e0f1d5519b8c2117068b603b08707a6bea761304c164e27876b4d7a69b6bf1669d3eb49198fc1a844aef1656d4c60b3dc83507b917697f7f7bc0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000432f30783563666238356431623764326133663838636234363434633565653036393563623034616430656434646232633164653963346263653631343430363635303800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000423078356366623835643162376432613366383863623436343463356565303639356362303461643065643464623263316465396334626365363134343036363530380000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000387893670d81b988fe9f67f568f8b68a5ed56bec", "to": "0x88B4C32618B9C26AE1500C6613Ac8a29b2Dc6e9C" }, invocation=null, revert={ "args": [ "Req::InvalidSignature" ], "name": "Error", "signature": "Error(string)" }, code=CALL_EXCEPTION, version=6.13.4)

Environment

No response

Environment (Other)

No response