-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: top level error catch #156
Conversation
4776fb6
to
fe94777
Compare
Is the idea to provide sentry feedback here? |
I would not do this. As a user it is very annoying when you get a meaningless error and you cannot do anything about it. It would make more sense to integrate this with the bug report dialog. |
Well, but it is also very annoying if you launch the app and nothing happens ;-) So what is more annoying? IMHO this should be displayed only in edge-cases like when the app crashes. We should otherwise catch other errors... Will that be the case? I don't know, but I would at least try it for the pre-release and see. Btw. this will be displayed only if the app crashes (as the error otherwise goes into the Electron framework which exits the app). |
No, that Feedback form is not present in Electron "world". We would have to somehow open Dashboard or something and display it there, which IMHO is not good idea. |
This catches on top-level errors and displays them as top-up. This is especially in order to not silently fail.