fix: read current password when constructing v3 wallet #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
approved these changes
Sep 9, 2022
| @@ -29,7 +29,7 @@ | |||
| "lint": "eslint --fix \"src/**/*.ts\" && cd ui && npm run lint", | |||
| "lint:check": "eslint \"src/**/*.ts\" && cd ui && npm run lint:check", | |||
| "check:types": "tsc --project tsconfig.test.json && cd ui && tsc --project tsconfig.test.json", | |||
| "test:unit": "jest --verbose -config=jest.config.ts " | |||
| "test:unit": "jest --verbose --config=jest.config.js" | |||
| @@ -0,0 +1,46 @@ | |||
| import { existsSync, unlinkSync, writeFileSync } from 'fs-extra' | |||
This was referenced Sep 9, 2022
This was referenced Jan 19, 2023
This was referenced Feb 23, 2023
This was referenced Mar 28, 2023
This was referenced Apr 27, 2023
This was referenced Aug 11, 2023
This was referenced Dec 6, 2023
This was referenced Jun 3, 2024
This was referenced Jul 25, 2024
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted password reading into a utility function.
Fixed tests, we only had one but that was outdated and did not run either. Would like to reintroduce testing our modules.