Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

reduce the number of errors in http access #112

Closed
7 tasks
cobordism opened this issue Jul 6, 2017 · 2 comments
Closed
7 tasks

reduce the number of errors in http access #112

cobordism opened this issue Jul 6, 2017 · 2 comments

Comments

@cobordism
Copy link

cobordism commented Jul 6, 2017

  • the GET request /favicon.ico should return our favicon bzz:/22481deec05d53e909e4f3933842686113927c67ab2a22c8ad5614e4e3dc505c/favicon.ico
  • the GET request for robots.txt should return a valid robots.txt
  • the default behaviour of any manifest should be to redirect to the entry for '/' and what was previously called the --defaultpath should be the entry at '/'
  • the GET request for just '/' (as opposed to bzz:/ etc.) should return a HTTP 200 and some minimal status info, not an error about an invalid protocol https://github.com/ethereum/go-ethereum/blob/master/swarm/api/http/server.go#L555
  • manifests without a default path should default to the behaviour that ?list=true induces. (Or at least it should be possible to enable this behaviour on the local node)
  • the GET request to /status should output a status page showing sync status, connected peers, disk usage etc. etc. ... possibly leading in future to a configuration assistant?
  • The configuration file should be populated with default values or should be edited manually.. currently empty entries in the config file are overwritten by any command line arguments. This leads to funky config files if the first time you run swarm you get an argument wrong. For example if I change httpaddr to '' in my config and then run swarm with --httpaddr doofus, then I'll have doofus stuck in my config until I change it manually.
@zelig
Copy link
Member

zelig commented Jul 6, 2017

@homotopycolimit great stuff, are you gonna tackle the fixes?

@gbalint
Copy link

gbalint commented Dec 13, 2017

The configuration file should be populated with default values or should be edited manually.. currently empty entries in the config file are overwritten by any command line arguments. This leads to funky config files if the first time you run swarm you get an argument wrong. For example if I change httpaddr to '' in my config and then run swarm with --httpaddr doofus, then I'll have doofus stuck in my config until I change it manually.

This should be solved by ethereum/go-ethereum#15548
The other points are covered by these issues:
#153
#154
#155
#156
#158
#162

@gbalint gbalint closed this as completed Dec 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants