Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

ci: run race detector on p2p packages #1249

Closed
2 tasks done
frncmx opened this issue Feb 20, 2019 · 3 comments · Fixed by ethereum/go-ethereum#19287
Closed
2 tasks done

ci: run race detector on p2p packages #1249

frncmx opened this issue Feb 20, 2019 · 3 comments · Fixed by ethereum/go-ethereum#19287
Assignees

Comments

@frncmx
Copy link
Contributor

frncmx commented Feb 20, 2019

In #1205 we only run -race for swarm/... as Elad suggests that would be great to run -race on p2p and cmd/swarm.

Let's try and see if something breaks.

Prerequisite issues

@frncmx
Copy link
Contributor Author

frncmx commented Mar 6, 2019

@justelad you suggested to extend the scope of the race detector job. I think that's a great idea now I'm trying to make tnat work.

You suggested to cover the whole p2p but after looking at it I think a lot of code we don't own there. What do you think if we run the race detector on the following packages?

  • cmd/swarm/...
  • p2p/{protocols,simulations,testing}/...

@acud
Copy link
Member

acud commented Mar 7, 2019

that would be great @frncmx. sounds good to me 👍

@frncmx frncmx changed the title ci: run race detector on p2p and cmd/swarm packages too ci: run race detector on p2p packages Mar 18, 2019
@frncmx
Copy link
Contributor Author

frncmx commented Mar 18, 2019

Covering cmd/swarm has been moved to #1301

(just to follow small incremental releases as cmd/swarm seems to take more time than expected)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants