Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing source dependencies inserts unexpected null #163

Open
belevy opened this issue Jul 6, 2023 · 0 comments
Open

Missing source dependencies inserts unexpected null #163

belevy opened this issue Jul 6, 2023 · 0 comments

Comments

@belevy
Copy link

belevy commented Jul 6, 2023

If you are using spago build but do not set spago: true the resulting output will contain something like

import * as Control_Applicative null

and cause a bad error that isn't particularly helpful. Perhaps there is a way to explain that this is caused by failure to find that module in your sources?

The requirement that all dependencies be specified as sources is unexpected since spago build will already include these dependencies for you. One question I have is whether it even makes sense to do the rewriting for dependencies since the whole purpose of that code seems to be to teach webpack about the compilers graph.

This issue shows up even more obviously when using https://github.com/purifix/purifix which doesn't store the dependencies in a single folder but rather copies the outputs from the nix store (in order to support incremental recompilation across packages).

Perhaps I am just chafing against the compilation model of Purescript here and the best option is to just include source dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant