should non exports namespace object keep __esModule flag?

[hardfist]

It seems that esbuild only add __esModule for export namespace object and not for internal namespace object.

input.ts

import * as answer from './answer'
globalThis.obj = {
  answer
}
console.log('ojb:', globalThis.obj)
export {
  answer
}

build.sh

 esbuild src/index.js --bundle --format=cjs --outfile=bundle.js

bundle.js

var __defProp = Object.defineProperty;
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
var __getOwnPropNames = Object.getOwnPropertyNames;
var __hasOwnProp = Object.prototype.hasOwnProperty;
var __markAsModule = (target) => __defProp(target, "__esModule", { value: true });
var __export = (target, all) => {
  for (var name in all)
    __defProp(target, name, { get: all[name], enumerable: true });
};
var __reExport = (target, module2, copyDefault, desc) => {
  if (module2 && typeof module2 === "object" || typeof module2 === "function") {
    for (let key of __getOwnPropNames(module2))
      if (!__hasOwnProp.call(target, key) && (copyDefault || key !== "default"))
        __defProp(target, key, { get: () => module2[key], enumerable: !(desc = __getOwnPropDesc(module2, key)) || desc.enumerable });
  }
  return target;
};
var __toCommonJS = /* @__PURE__ */ ((cache) => {
  return (module2, temp) => {
    return cache && cache.get(module2) || (temp = __reExport(__markAsModule({}), module2, 1), cache && cache.set(module2, temp), temp);
  };
})(typeof WeakMap !== "undefined" ? /* @__PURE__ */ new WeakMap() : 0);

// src/index.js
var src_exports = {};
__export(src_exports, {
  answer: () => answer_exports
});

// src/answer.js
var answer_exports = {};
__export(answer_exports, {
  default: () => answer_default
});
var answer = 42;
var answer_default = answer;

// src/index.js
globalThis.obj = {
  answer: answer_exports
};
console.log("ojb:", globalThis.obj);
module.exports = __toCommonJS(src_exports);

The globalThis.obj.answer doesn't contains __ESModule flags, which cause problem when globalThis.obj.answer is used in another module loader(like amd).

but webpack generated __esModule flags for both internal and exports namespace object.

[evanw]

This is very deliberate. People want to be able to use __esModule as an ESM export name via export { __esModule }: #1591. So esbuild no longer introduces __esModule into ESM exports at all. If you want __esModule you should import the module with require() instead of import. Only CommonJS-style imports get __esModule.

[hardfist]

Oh, that make sense，so it's not an good idea for runtime to rely on this feature