Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling fails with TypeScript 4 catch clause bindings #435

Closed
bkiac opened this issue Oct 6, 2020 · 1 comment
Closed

Bundling fails with TypeScript 4 catch clause bindings #435

bkiac opened this issue Oct 6, 2020 · 1 comment

Comments

@bkiac
Copy link

bkiac commented Oct 6, 2020

Build with --bundle fails if code has unknown on catch clause bindings.
I'm not sure if this is expected because the type system should be irrelevant for esbuild, but I can't get it to work.

Here is my error:

$ yarn esbuild --bundle src/index.ts --minify --sourcemap
src/hooks/useRequest.ts:160:18: error: Expected ")" but found ":"
        } catch (error: unknown) {
                      ^
1 error
error Command failed with exit code 1.
@evanw evanw closed this as completed in 8809415 Oct 6, 2020
@evanw
Copy link
Owner

evanw commented Oct 6, 2020

Thanks for the report. I didn't catch this in the recent TypeScript release notes. Just fixed it in version 0.7.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants