From c8f86b7dadeddfcadba5bdda56f09e9ebe05577d Mon Sep 17 00:00:00 2001
From: Craig Roberts <github@craig.craig0990.co.uk>
Date: Thu, 23 Jan 2025 18:08:12 +0800
Subject: [PATCH] feat(core): use `gray-matter` to `stringify` dependencies
 frontmatter (#1083)

Fixes #1081

Co-authored-by: Craig Roberts <git@craig.craig0990.co.uk>
---
 .changeset/quote-dependencies-frontmatter.md  |  5 +++
 .../eventcatalog.config.js                    |  4 +++
 .../resolve-catalog-dependencies.spec.ts      | 22 +++++++++++++
 src/resolve-catalog-dependencies.js           | 33 +++++++++----------
 4 files changed, 47 insertions(+), 17 deletions(-)
 create mode 100644 .changeset/quote-dependencies-frontmatter.md

diff --git a/.changeset/quote-dependencies-frontmatter.md b/.changeset/quote-dependencies-frontmatter.md
new file mode 100644
index 00000000..7d842dd3
--- /dev/null
+++ b/.changeset/quote-dependencies-frontmatter.md
@@ -0,0 +1,5 @@
+---
+"@eventcatalog/core": patch
+---
+
+fix(core): fixed dependencies frontmatter quoting when values would be interpreted as non-scalar
\ No newline at end of file
diff --git a/src/__tests__/example-catalog-dependencies/eventcatalog.config.js b/src/__tests__/example-catalog-dependencies/eventcatalog.config.js
index 80155ef0..e293b42e 100644
--- a/src/__tests__/example-catalog-dependencies/eventcatalog.config.js
+++ b/src/__tests__/example-catalog-dependencies/eventcatalog.config.js
@@ -35,6 +35,10 @@ export default {
     services: [
       { id: 'TestingServiceOrder', version: '5.0.0' }
     ],
+    channels: [
+      { id: 'TestingChannelOrder', version: '5.0.0'},
+      { id: '{env}.testing.channel.order', version: '5.0.0'}
+    ],
     domains: [
       { id: 'TestingDomainOrder', version: '5.0.0' }
     ],
diff --git a/src/__tests__/resolve-catalog-dependencies.spec.ts b/src/__tests__/resolve-catalog-dependencies.spec.ts
index ac6d03bc..91ef477c 100644
--- a/src/__tests__/resolve-catalog-dependencies.spec.ts
+++ b/src/__tests__/resolve-catalog-dependencies.spec.ts
@@ -90,5 +90,27 @@ describe('resolve-catalog-dependencies', () => {
         expect(content).toContain('version: 5.0.0');
       });
     });
+
+    describe('channels', () => {
+      it('creates a dependency file for each channel', async () => {
+        const content = await fs.readFile(
+          path.join(CATALOG_DIR, 'dependencies', 'channels', 'TestingChannelOrder', 'index.md'),
+          'utf8'
+        );
+        expect(content).toContain('id: TestingChannelOrder');
+        expect(content).toContain('name: TestingChannelOrder');
+        expect(content).toContain('version: 5.0.0');
+      });
+
+      it('creates a dependency file for parameterized channels', async () => {
+        const content = await fs.readFile(
+          path.join(CATALOG_DIR, 'dependencies', 'channels', '{env}.testing.channel.order', 'index.md'),
+          'utf8'
+        );
+        expect(content).toContain(`id: '{env}.testing.channel.order'`);
+        expect(content).toContain(`name: '{env}.testing.channel.order'`);
+        expect(content).toContain('version: 5.0.0');
+      });
+    });
   });
 });
diff --git a/src/resolve-catalog-dependencies.js b/src/resolve-catalog-dependencies.js
index 2043dbc7..3105b169 100644
--- a/src/resolve-catalog-dependencies.js
+++ b/src/resolve-catalog-dependencies.js
@@ -1,6 +1,7 @@
 import { getEventCatalogConfigFile } from './eventcatalog-config-file-utils';
 import path from 'node:path';
 import fs from 'node:fs';
+import matter from 'gray-matter';
 
 // Create a fake file for this dependency in the project directory ()
 
@@ -27,27 +28,25 @@ export default async (catalogDir, core) => {
   const resourceTypes = Object.keys(dependencies);
   for (const resourceType of resourceTypes) {
     for (const dependency of dependencies[resourceType]) {
-      const resource = {
+      const frontmatter = {
         id: dependency.id,
+        name: dependency.id,
         version: dependency.version || '1.0.0',
       };
 
-      const markdown = `---
-id: ${resource.id}
-name: ${resource.id}
-version: ${resource.version}
----
-
-:::warning
-
-You are running EventCatalog with dependencies enabled.
-
-This resource is mocked and is a dependency. This means that the resource is managed and owned by another catalog.
-:::
-
-`;
-
-      const resourceFile = path.join(dependenciesDir, resourceType, resource.id, `index.md`);
+      const markdown = matter.stringify(
+        {
+          content: [
+            ':::warning',
+            'You are running EventCatalog with dependencies enabled.',
+            'This resource is mocked and is a dependency. This means that the resource is managed and owned by another catalog.',
+            ':::',
+          ].join('\n\n'),
+        },
+        frontmatter
+      );
+
+      const resourceFile = path.join(dependenciesDir, resourceType, dependency.id, `index.md`);
       // ensure the directory exists
       fs.mkdirSync(path.dirname(resourceFile), { recursive: true });
       fs.writeFileSync(resourceFile, markdown);