Saga's, Commands and Events not registered?

[wernert71]

It might just be me, but when I load the assembly that contains the commands, aggregates, and sagas, they don’t seem to get added to the service collection. This might have something to do with the way EventFlowOptions is constructed.

Currently, RegisterDefaults is called inside the constructor, like this:

private EventFlowOptions(IServiceCollection serviceCollection)
{
    ServiceCollection = serviceCollection;
    RegisterDefaults(ServiceCollection);
}

The problem is that AddDefaults can only be called on an instance of IEventFlowOptions, which means that any types retrieved from the assembly passed to AddDefaults will never actually get registered, since RegisterDefaults has already been called during construction.

I would like to suggest

Adding a method to IEventFlowOptions, something like ApplyRegistrations(), which would handle the actual registration at the right time:

serviceCollection.TryAddSingleton<ILoadedVersionedTypes>(r => new LoadedVersionedTypes(
    _jobTypes,
    _commandTypes,
    _aggregateEventTypes,
    _sagaTypes,
    _snapshotTypes));

This way, registration happens after all types have been added by AddDefaults.

Or… maybe I missed something! 🙂
Would love to hear your thoughts.