Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving JS/CSS files from fragment #11

Open
fbrandel opened this issue Mar 21, 2018 · 1 comment
Open

Resolving JS/CSS files from fragment #11

fbrandel opened this issue Mar 21, 2018 · 1 comment

Comments

@fbrandel
Copy link

I see that the src attribute of an image tag gets automatically rewritten to use the full URL to the "remote" service.

For <script> and <link> tags this is not the case. Is there a reason for that?

As pointed out in the documentation, scripts and css files could be loaded with the /cui-req://prefix, but in the remote service I just want to include the scripts/css with a relative path starting with '/'.

So I think it would be great if these relative paths also get rewritten/prefixed with the services URL.

@andrewserff
Copy link
Member

Yes, I see how that could be helpful. Our use case didn't need that as really, we weren't ever using the UI in the remote microservice by itself. So we always referenced the javascript with the /cui-req in our main ui service. I'll see if I can get it to scrape the script and link tags as well. If you have time to do it, please do and submit a PR as I'm not sure when I'll get to it. But thanks pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants