Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No updates when updates arrive in bursts #5

Open
steve36871 opened this issue May 6, 2022 · 0 comments
Open

No updates when updates arrive in bursts #5

steve36871 opened this issue May 6, 2022 · 0 comments

Comments

@steve36871
Copy link

Due to below line in the code, the updates do not arrive when they come in bursts.
In practice, I encountered a case where 3/4 of the process happened immediately (due to caching), but the progress bar stayed at 0 for the next hour.

if (time_delta >= self.update_interval) or (self._progress == self.total):

Instead of only basing updates based on time, perhaps it would be good to also update if the progress was significantly changed or maybe just based on the progress difference instead of time? I think updates based on the amount of progress - say at least 1/4000th of progress - might make sense, because most displays cannot display more than 4000 pixels in the width anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant