From b53712d2cb3348b6183e4ee68d43a98f1a5f847a Mon Sep 17 00:00:00 2001 From: Will Cory Date: Sun, 22 Sep 2024 12:54:51 -0700 Subject: [PATCH] :bug: Fix: Broken tree shaking (#1449) ## Description _Concise description of proposed changes_ ## Testing Explain the quality checks that have been done on the code changes ## Additional Information - [ ] I read the [contributing docs](../docs/contributing.md) (if this is your first contribution) Your ENS/address: Co-authored-by: William Cory --- .changeset/polite-teachers-worry.md | 56 ++++++++++++++++++++ bundler-packages/base-bundler/package.json | 4 +- bundler-packages/bun/package.json | 2 +- bundler-packages/bundler-cache/package.json | 2 +- bundler-packages/compiler/package.json | 4 +- bundler-packages/config/package.json | 4 +- bundler-packages/esbuild/package.json | 4 +- bundler-packages/resolutions/package.json | 4 +- bundler-packages/rollup/package.json | 4 +- bundler-packages/rspack/package.json | 4 +- bundler-packages/runtime/package.json | 4 +- bundler-packages/solc/package.json | 4 +- bundler-packages/unplugin/package.json | 2 +- bundler-packages/vite/package.json | 4 +- bundler-packages/webpack/package.json | 4 +- bundler-packages/whatsabi/package.json | 4 +- configs/tsconfig/package.json | 4 +- configs/tsupconfig/package.json | 4 +- extensions/ethers/package.json | 4 +- extensions/viem/package.json | 4 +- lsp/lsp/package.json | 4 +- lsp/ts-plugin/package.json | 2 +- packages/actions/package.json | 4 +- packages/address/package.json | 4 +- packages/block/package.json | 4 +- packages/blockchain/package.json | 4 +- packages/client-types/package.json | 4 +- packages/common/package.json | 4 +- packages/contract/package.json | 4 +- packages/decorators/package.json | 4 +- packages/effect/package.json | 4 +- packages/errors/package.json | 4 +- packages/evm/package.json | 4 +- packages/http-client/package.json | 2 +- packages/jsonrpc/package.json | 4 +- packages/logger/package.json | 4 +- packages/memory-client/package.json | 4 +- packages/node/package.json | 4 +- packages/precompiles/package.json | 4 +- packages/predeploys/package.json | 4 +- packages/procedures/package.json | 4 +- packages/receipt-manager/package.json | 4 +- packages/rlp/package.json | 4 +- packages/server/package.json | 4 +- packages/state/package.json | 4 +- packages/sync-storage-persister/package.json | 2 +- packages/trie/package.json | 4 +- packages/tx/package.json | 4 +- packages/txpool/package.json | 4 +- packages/utils/package.json | 4 +- packages/vm/package.json | 4 +- test/test-utils/package.json | 4 +- tevm/package.json | 4 +- 53 files changed, 154 insertions(+), 98 deletions(-) create mode 100644 .changeset/polite-teachers-worry.md diff --git a/.changeset/polite-teachers-worry.md b/.changeset/polite-teachers-worry.md new file mode 100644 index 0000000000..2076318f11 --- /dev/null +++ b/.changeset/polite-teachers-worry.md @@ -0,0 +1,56 @@ +--- +"@tevm/sync-storage-persister": patch +"@tevm/bundler-cache": patch +"@tevm/base-bundler": patch +"@tevm/resolutions": patch +"@tevm/compiler": patch +"@tevm/unplugin": patch +"@tevm/whatsabi": patch +"@tevm/esbuild-plugin": patch +"@tevm/runtime": patch +"@tevm/webpack-plugin": patch +"@tevm/receipt-manager": patch +"@tevm/config": patch +"@tevm/rollup-plugin": patch +"@tevm/rspack-plugin": patch +"@tevm/memory-client": patch +"@tevm/solc": patch +"@tevm/vite-plugin": patch +"@tevm/client-types": patch +"@tevm/bun-plugin": patch +"@tevm/http-client": patch +"@tevm/precompiles": patch +"@tevm/blockchain": patch +"@tevm/decorators": patch +"@tevm/predeploys": patch +"@tevm/procedures": patch +"@tevm/tsupconfig": patch +"@tevm/ethers": patch +"@tevm/contract": patch +"@tevm/tsconfig": patch +"@tevm/actions": patch +"@tevm/address": patch +"@tevm/jsonrpc": patch +"@tevm/viem": patch +"@tevm/common": patch +"@tevm/effect": patch +"@tevm/errors": patch +"@tevm/logger": patch +"@tevm/server": patch +"@tevm/txpool": patch +"@tevm/test-utils": patch +"@tevm/block": patch +"@tevm/state": patch +"@tevm/utils": patch +"@tevm/ts-plugin": patch +"@tevm/node": patch +"@tevm/trie": patch +"@tevm/evm": patch +"@tevm/rlp": patch +"@tevm/tx": patch +"@tevm/vm": patch +"@tevm/lsp": patch +"tevm": patch +--- + +Fixed typo in package.json that eliminated tevm ability to treeshake diff --git a/bundler-packages/base-bundler/package.json b/bundler-packages/base-bundler/package.json index 0cc66be994..75dcf62365 100644 --- a/bundler-packages/base-bundler/package.json +++ b/bundler-packages/base-bundler/package.json @@ -77,5 +77,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/bun/package.json b/bundler-packages/bun/package.json index c2a01b80f0..aa9711467c 100644 --- a/bundler-packages/bun/package.json +++ b/bundler-packages/bun/package.json @@ -76,5 +76,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false + "sideEffects": false } \ No newline at end of file diff --git a/bundler-packages/bundler-cache/package.json b/bundler-packages/bundler-cache/package.json index 7b63a8cea7..d0e0760d40 100644 --- a/bundler-packages/bundler-cache/package.json +++ b/bundler-packages/bundler-cache/package.json @@ -75,5 +75,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false + "sideEffects": false } \ No newline at end of file diff --git a/bundler-packages/compiler/package.json b/bundler-packages/compiler/package.json index 4ea31c4e06..ccaad08b27 100644 --- a/bundler-packages/compiler/package.json +++ b/bundler-packages/compiler/package.json @@ -80,5 +80,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/config/package.json b/bundler-packages/config/package.json index 86c3d4c334..3f66cb6eba 100644 --- a/bundler-packages/config/package.json +++ b/bundler-packages/config/package.json @@ -78,5 +78,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/esbuild/package.json b/bundler-packages/esbuild/package.json index f3180a1057..0f7a7827be 100644 --- a/bundler-packages/esbuild/package.json +++ b/bundler-packages/esbuild/package.json @@ -68,5 +68,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/resolutions/package.json b/bundler-packages/resolutions/package.json index 27fd78b9be..85b35c9dbc 100644 --- a/bundler-packages/resolutions/package.json +++ b/bundler-packages/resolutions/package.json @@ -75,5 +75,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/rollup/package.json b/bundler-packages/rollup/package.json index 0f4935c024..59c3701917 100644 --- a/bundler-packages/rollup/package.json +++ b/bundler-packages/rollup/package.json @@ -67,5 +67,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/rspack/package.json b/bundler-packages/rspack/package.json index 8d94e55d26..96f57cfd3b 100644 --- a/bundler-packages/rspack/package.json +++ b/bundler-packages/rspack/package.json @@ -67,5 +67,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/runtime/package.json b/bundler-packages/runtime/package.json index 46138aebae..4df7e33d01 100644 --- a/bundler-packages/runtime/package.json +++ b/bundler-packages/runtime/package.json @@ -73,5 +73,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/solc/package.json b/bundler-packages/solc/package.json index 01f4d44017..b343298335 100644 --- a/bundler-packages/solc/package.json +++ b/bundler-packages/solc/package.json @@ -70,5 +70,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/unplugin/package.json b/bundler-packages/unplugin/package.json index 88315e219e..f25188b0f1 100644 --- a/bundler-packages/unplugin/package.json +++ b/bundler-packages/unplugin/package.json @@ -78,5 +78,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false + "sideEffects": false } \ No newline at end of file diff --git a/bundler-packages/vite/package.json b/bundler-packages/vite/package.json index 67fb607400..f534ca4b29 100644 --- a/bundler-packages/vite/package.json +++ b/bundler-packages/vite/package.json @@ -67,5 +67,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/webpack/package.json b/bundler-packages/webpack/package.json index 56ba67b677..e7c623da2e 100644 --- a/bundler-packages/webpack/package.json +++ b/bundler-packages/webpack/package.json @@ -71,5 +71,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/bundler-packages/whatsabi/package.json b/bundler-packages/whatsabi/package.json index 5e490f3e3b..02d1c98c0a 100644 --- a/bundler-packages/whatsabi/package.json +++ b/bundler-packages/whatsabi/package.json @@ -74,5 +74,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/configs/tsconfig/package.json b/configs/tsconfig/package.json index 39f3b93d35..723edcc78a 100644 --- a/configs/tsconfig/package.json +++ b/configs/tsconfig/package.json @@ -5,5 +5,5 @@ "files": [ "base.json" ], - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/configs/tsupconfig/package.json b/configs/tsupconfig/package.json index da97870c89..df67752844 100644 --- a/configs/tsupconfig/package.json +++ b/configs/tsupconfig/package.json @@ -42,5 +42,5 @@ "@tevm/tsconfig": "workspace:^", "@types/node": "^22.5.1" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/extensions/ethers/package.json b/extensions/ethers/package.json index 617df8fbb3..246d624d0c 100644 --- a/extensions/ethers/package.json +++ b/extensions/ethers/package.json @@ -82,5 +82,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/extensions/viem/package.json b/extensions/viem/package.json index 6a29f6ada1..f8154ba2a8 100644 --- a/extensions/viem/package.json +++ b/extensions/viem/package.json @@ -90,5 +90,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/lsp/lsp/package.json b/lsp/lsp/package.json index 2cf8d638dd..bc2990eaad 100644 --- a/lsp/lsp/package.json +++ b/lsp/lsp/package.json @@ -2,7 +2,7 @@ "name": "@tevm/lsp", "version": "1.0.0-next.109", "private": false, - "sideEffect": false, + "sideEffects": false, "description": "The language server for Tevm", "type": "module", "main": "dist/index.js", @@ -50,4 +50,4 @@ "typescript": "^5.4.5", "vitest": "^1.6.0" } -} +} \ No newline at end of file diff --git a/lsp/ts-plugin/package.json b/lsp/ts-plugin/package.json index 9a76f0fbad..8d2ec23f01 100644 --- a/lsp/ts-plugin/package.json +++ b/lsp/ts-plugin/package.json @@ -2,7 +2,7 @@ "name": "@tevm/ts-plugin", "version": "1.0.0-next.109", "private": false, - "sideEffect": false, + "sideEffects": false, "description": "A typescript plugin for tevm", "keywords": [ "typescript", diff --git a/packages/actions/package.json b/packages/actions/package.json index 185e3b4f7c..b9feca992b 100644 --- a/packages/actions/package.json +++ b/packages/actions/package.json @@ -91,5 +91,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/address/package.json b/packages/address/package.json index 97f6dce28c..463f22efe3 100644 --- a/packages/address/package.json +++ b/packages/address/package.json @@ -75,5 +75,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/block/package.json b/packages/block/package.json index 823c7fd78b..148a692f54 100644 --- a/packages/block/package.json +++ b/packages/block/package.json @@ -76,5 +76,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/blockchain/package.json b/packages/blockchain/package.json index 52938f8396..d9a1c1d989 100644 --- a/packages/blockchain/package.json +++ b/packages/blockchain/package.json @@ -82,5 +82,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/client-types/package.json b/packages/client-types/package.json index db6551349e..5e7876f510 100644 --- a/packages/client-types/package.json +++ b/packages/client-types/package.json @@ -70,5 +70,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/common/package.json b/packages/common/package.json index 928622184c..dbe36dfc3d 100644 --- a/packages/common/package.json +++ b/packages/common/package.json @@ -77,5 +77,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/contract/package.json b/packages/contract/package.json index d2ebf65ca1..b960dbb2a8 100644 --- a/packages/contract/package.json +++ b/packages/contract/package.json @@ -77,5 +77,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/decorators/package.json b/packages/decorators/package.json index e933028fc5..3bb91aae91 100644 --- a/packages/decorators/package.json +++ b/packages/decorators/package.json @@ -78,5 +78,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/effect/package.json b/packages/effect/package.json index 8ba2ab5865..0816697c80 100644 --- a/packages/effect/package.json +++ b/packages/effect/package.json @@ -70,5 +70,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/errors/package.json b/packages/errors/package.json index fe56a799e2..a52ca3274a 100644 --- a/packages/errors/package.json +++ b/packages/errors/package.json @@ -74,5 +74,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/evm/package.json b/packages/evm/package.json index bb033488ca..bf964913b1 100644 --- a/packages/evm/package.json +++ b/packages/evm/package.json @@ -78,5 +78,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/http-client/package.json b/packages/http-client/package.json index 73a50d5f35..fc36b76ea6 100644 --- a/packages/http-client/package.json +++ b/packages/http-client/package.json @@ -80,5 +80,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false + "sideEffects": false } \ No newline at end of file diff --git a/packages/jsonrpc/package.json b/packages/jsonrpc/package.json index 1f22c05caf..bc45f63221 100644 --- a/packages/jsonrpc/package.json +++ b/packages/jsonrpc/package.json @@ -76,5 +76,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/logger/package.json b/packages/logger/package.json index 0a9290ca14..d02f43dd0f 100644 --- a/packages/logger/package.json +++ b/packages/logger/package.json @@ -71,5 +71,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/memory-client/package.json b/packages/memory-client/package.json index 2a3955b702..3cabc371f2 100644 --- a/packages/memory-client/package.json +++ b/packages/memory-client/package.json @@ -85,5 +85,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/node/package.json b/packages/node/package.json index a17ce752d1..d617921aeb 100644 --- a/packages/node/package.json +++ b/packages/node/package.json @@ -89,5 +89,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/precompiles/package.json b/packages/precompiles/package.json index bf67ea65cd..cee3646b2f 100644 --- a/packages/precompiles/package.json +++ b/packages/precompiles/package.json @@ -73,5 +73,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/predeploys/package.json b/packages/predeploys/package.json index 435f4b21f3..f9cb208de4 100644 --- a/packages/predeploys/package.json +++ b/packages/predeploys/package.json @@ -75,5 +75,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/procedures/package.json b/packages/procedures/package.json index d4952f0e73..cfafed1d57 100644 --- a/packages/procedures/package.json +++ b/packages/procedures/package.json @@ -88,5 +88,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/receipt-manager/package.json b/packages/receipt-manager/package.json index 3772b1969d..63ca1ce68c 100644 --- a/packages/receipt-manager/package.json +++ b/packages/receipt-manager/package.json @@ -76,5 +76,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/rlp/package.json b/packages/rlp/package.json index 82b720b8b1..6a6334c088 100644 --- a/packages/rlp/package.json +++ b/packages/rlp/package.json @@ -71,5 +71,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/server/package.json b/packages/server/package.json index 631dd42e4c..781f1c5abb 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -87,5 +87,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/state/package.json b/packages/state/package.json index 38ee9d80cf..0e0ab1ba89 100644 --- a/packages/state/package.json +++ b/packages/state/package.json @@ -81,5 +81,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/sync-storage-persister/package.json b/packages/sync-storage-persister/package.json index 3840badf43..93ff175296 100644 --- a/packages/sync-storage-persister/package.json +++ b/packages/sync-storage-persister/package.json @@ -71,5 +71,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false + "sideEffects": false } \ No newline at end of file diff --git a/packages/trie/package.json b/packages/trie/package.json index 5f8d8c6092..d02f26b704 100644 --- a/packages/trie/package.json +++ b/packages/trie/package.json @@ -71,5 +71,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/tx/package.json b/packages/tx/package.json index 447157c0da..aed34a5cd2 100644 --- a/packages/tx/package.json +++ b/packages/tx/package.json @@ -74,5 +74,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/txpool/package.json b/packages/txpool/package.json index c84e4ad641..f8d3008f4f 100644 --- a/packages/txpool/package.json +++ b/packages/txpool/package.json @@ -79,5 +79,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/utils/package.json b/packages/utils/package.json index c1577e35f2..a30c935151 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -77,5 +77,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/packages/vm/package.json b/packages/vm/package.json index d3315fa03b..6966381e32 100644 --- a/packages/vm/package.json +++ b/packages/vm/package.json @@ -85,5 +85,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file diff --git a/test/test-utils/package.json b/test/test-utils/package.json index bc1098fd8f..6f598058da 100644 --- a/test/test-utils/package.json +++ b/test/test-utils/package.json @@ -2,7 +2,7 @@ "name": "@tevm/test-utils", "version": "1.0.0-next.109", "private": false, - "sideEffect": false, + "sideEffects": false, "description": "Testing utils and fixtures for tevm", "keywords": [ "solidity", @@ -79,4 +79,4 @@ "peerDependencies": { "viem": "^2.21.1" } -} +} \ No newline at end of file diff --git a/tevm/package.json b/tevm/package.json index 03527c0820..8d3adc4803 100644 --- a/tevm/package.json +++ b/tevm/package.json @@ -476,5 +476,5 @@ "publishConfig": { "access": "public" }, - "sideEffect": false -} + "sideEffects": false +} \ No newline at end of file