Generator fails with partial classes

[powerdude]

Hi,

If your code has something like the following:

partial class MyPage
{
}

public partial class MyPage : ContentPage 
{
}

The following warning is generated:

2>CSC : warning CS8785: Generator 'RouteGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'ArgumentException' with message 'An item with the same key has already been added.'.

This should probably be an error though since no file is actually generated.

[ewerspej]

Hi @powerdude ,

thanks for reporting this.

CS8785 is not issued by the Route Generator, it's a warning from the Roslyn compiler platform. The Route Generator seems to throw an unhandled exception due to a duplicate key.

I'll look into this.

Cheers

[ewerspej]

Fixed with 1.0.3
NuGet: https://www.nuget.org/packages/epj.RouteGenerator/1.0.3

[powerdude]

Sorry, one more thing was discovered once this issue was fixed. Errors are generated for the following.

internal abstract class BaseContentPage<T> : ContentPage where T : BaseViewModel
{
    protected BaseContentPage(T viewModel, string pageTitle)
    {
        base.BindingContext = viewModel;

        Title = pageTitle;
    }

    protected new T BindingContext => (T)base.BindingContext;
}

I can work work around it temporarily by renaming the class.

[ewerspej]

I opened a separate issue for this: #10.