Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secret ALTERNATIVE_GITHUB_TOKEN from GitHub workflows #339

Open
ckunki opened this issue Jan 16, 2025 · 0 comments · May be fixed by #345
Open

Remove secret ALTERNATIVE_GITHUB_TOKEN from GitHub workflows #339

ckunki opened this issue Jan 16, 2025 · 0 comments · May be fixed by #345
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Jan 16, 2025 •
edited
Loading

Currently, we don't have any evidence that this secret is used by any project.
Also not github-issue-adapter.
See https://github.com/search?q=org%3Aexasol+ALTERNATIVE_GITHUB_TOKEN&type=code&p=2

Still, the default GitHub workflows provided by the PTB contain support for this secret.

The current ticket therefore asks to remove this support.
@ahsimb ahsimb added the refactoring Code improvement without behavior change label Jan 17, 2025
Jannis-Mittenzwei added a commit that referenced this issue Jan 24, 2025
@Jannis-Mittenzwei
Merge branch 'main' into refactoring/#339-Remove-secret-ALTERNATIVE_G…
69b2b56 
…ITHUB_TOKEN-from-GitHub-workflows
@Jannis-Mittenzwei Jannis-Mittenzwei linked a pull request Jan 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove secret ALTERNATIVE_GITHUB_TOKEN from GitHub workflows exasol/python-toolbox
2 participants
@ahsimb @ckunki