Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The FolderObjectStorage class SaveObject<T>method has a issues #246

Closed
d18zj opened this issue Mar 11, 2021 · 1 comment
Closed

The FolderObjectStorage class SaveObject<T>method has a issues #246

d18zj opened this issue Mar 11, 2021 · 1 comment

Comments

@d18zj
Copy link
Contributor

d18zj commented Mar 11, 2021

When log level is changed from DEBUG to INFO, The client-side server-settings.json file will be incorrect.
``

{"@@UserAgentBotPatterns":"bot,crawler,spider,aolbuild,teoma,yahoo","@@log:*":"debug"}
``

After the update, there is an additional } sign at the end

{"@@UserAgentBotPatterns":"*bot*,*crawler*,*spider*,*aolbuild*,*teoma*,*yahoo*","@@log:*":"info"}}

should modify FolderObjectStorage.cs like this:
image

@d18zj d18zj changed the title Then FolderObjectStorage class SaveObject<T>method has a issues The FolderObjectStorage class SaveObject<T>method has a issues Mar 11, 2021
@niemyjski
Copy link
Member

Thanks for this report and nice find! I wonder why we did OpenWrite there. Is there any chance you could create a test and submit this change in a pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants