Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ruff #769

Closed
3 tasks
adam-grant-hendry opened this issue Oct 18, 2023 · 3 comments · Fixed by #776
Closed
3 tasks

Switch to ruff #769

adam-grant-hendry opened this issue Oct 18, 2023 · 3 comments · Fixed by #776
Labels
enhancement New feature or request

Comments

@adam-grant-hendry
Copy link

Context

flake8 takes a long time to run (i.e. pre-commit). It would be nicer to use ruff.

Proposal

  1. Remove flake8 as a dependency, including the .flake8 file.
  2. Add ruff rules to pyproject.toml file
  3. Modify .pre-commit-config.yaml to use ruff

Tasks and updates

  • Remove flake8 as a dependency, including the .flake8 file.
  • Add ruff rules to pyproject.toml file
  • Modify .pre-commit-config.yaml to use ruff
@adam-grant-hendry adam-grant-hendry added the enhancement New feature or request label Oct 18, 2023
@choldgraf
Copy link
Member

Makes sense to me - I think that @agoose77 recently updated to ruff on some other projects in EB as well.

@adam-grant-hendry
Copy link
Author

@choldgraf @agoose77 flake8 takes the longest linting time, not black. Can we reopen this until we switch from flake8 to ruff?

@agoose77
Copy link
Collaborator

We should do both - let me check, I thought I'd removed flake8 but it's been a very long week...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants