Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return type for convert(char result[], int drops) in "Raindrop" should be of type void #968

Closed
Ashvith10 opened this issue Apr 3, 2024 · 2 comments · Fixed by #969
Closed

Return type for convert(char result[], int drops) in "Raindrop" should be of type void #968

Ashvith10 opened this issue Apr 3, 2024 · 2 comments · Fixed by #969

Comments

@Ashvith10
Copy link
Contributor

Since the test cases do not make use of returned value, and it is clear from the overview that the argument is used to pass the string by reference, it makes sense to use void instead. Learners might be confuse this behavior.
@wolf99
Copy link
Contributor

wolf99 commented Apr 3, 2024

I'm ok with this.
Would you like to make a PR with this change @Ashvith10 ?

@Ashvith10 Ashvith10 mentioned this issue Apr 4, 2024
Merged
@Ashvith10
Copy link
Contributor Author

@wolf99 I've created a PR for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Amend the return type of function in raindrop Ashvith10/c
2 participants
@wolf99 @Ashvith10