Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: consider adding configlet upgrade command #574

Closed
ee7 opened this issue Apr 26, 2022 · 0 comments
Closed

upgrade: consider adding configlet upgrade command #574

ee7 opened this issue Apr 26, 2022 · 0 comments
Labels
kind: design Discussing overall direction status: wont do/fix This will not be worked on

Comments

@ee7
Copy link
Member

ee7 commented Apr 26, 2022

Running configlet upgrade would make configlet upgrade itself. This command existed in the configlet for Exercism v2.

For my own interest, I had a local branch with a proof-of-concept implementation of this a while ago.

But the argument against it is:

  • Maintenance burden: it adds lines of code and complexity to configlet.
  • It increases the size of the configlet executable.
  • We already have fetch-configlet.
  • Even if we had configlet upgrade, we still want fetch-configlet for cases when configlet is not installed (e.g. in CI, or a user's first download), so we'd have maintain two codebases for downloading configlet.
  • It's not like every command-line tool has self-upgrade functionality. In fact, it would be bad if every tool did - it's better handled by a package manager.
  • It would have to handle the case of a user installing configlet system-wide, where configlet upgrade does not have write permission to upgrade itself. And I don't want to advise people to run configlet upgrade with e.g. sudo.

Related: #408, #153

@ee7 ee7 added status: wont do/fix This will not be worked on kind: design Discussing overall direction labels Apr 26, 2022
@ee7 ee7 closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: design Discussing overall direction status: wont do/fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant