Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually update tests to version 3 #35

Closed
jiegillet opened this issue Mar 26, 2022 · 4 comments
Closed

Actually update tests to version 3 #35

jiegillet opened this issue Mar 26, 2022 · 4 comments

Comments

@jiegillet
Copy link
Contributor

Currently we mark the results.json with a "version": 3, but it's not actually earned.
According to the docs, version 3 means that the test runner can link individual tests to a task, which we don't do.

According to this discussion, it involves updating the version of elm-test-rs.
It will also involve a large PR in exercism/elm to tag all the concept exercise tests to their task.

@jiegillet jiegillet changed the title Actually ipdate tests to version 3 Actually update tests to version 3 Mar 26, 2022
@jiegillet
Copy link
Contributor Author

I forgot to mention that the UI for showing the task ID is live now.

Screen Shot 2022-03-26 at 21 09 33

@mpizenberg
Copy link
Member

I forgot to mention that the UI for showing the task ID is live now

🎉

@mpizenberg
Copy link
Member

Really nice to have the UI for tasks :)
My bad, must be my mistake if I updated the version to 3 while this was meant for tests categorized by tasks. Or the version 3 spec changed at some point to include those.
The good thing about still having a relatively small learning track is that it won't be that big to update a few tests files. Usually, tests are already close together for the same task. So it will only be a matter of transforming tests descriptions like this:

-- before
describe "concept"
  [ test "test 1a" <| ...
  , test "test 1b" <| ...
  , test "test 2a" <| ...
  ]

-- after
describe "concept"
  [ describe "1" -- the task id
    [ test "test 1a" <| ...
    , test "test 1b" <| ...
    ]
  , describe "2"
    [ test "test 2a" <| ...
    ]
  ]

@jiegillet
Copy link
Contributor Author

Closed via #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants