From bb0160dfbe5fc04a2f411431ae5b2d27f5ff1c65 Mon Sep 17 00:00:00 2001 From: manumafe98 Date: Thu, 21 Mar 2024 15:17:14 -0300 Subject: [PATCH 1/4] Adding analyzer feedback for tim-from-marketing concept exercise --- .../concept/tim-from-marketing/.meta/design.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/exercises/concept/tim-from-marketing/.meta/design.md b/exercises/concept/tim-from-marketing/.meta/design.md index 4fba63130..4bd63438e 100644 --- a/exercises/concept/tim-from-marketing/.meta/design.md +++ b/exercises/concept/tim-from-marketing/.meta/design.md @@ -18,3 +18,16 @@ - `strings`: strings will be compared to null and basic methods from strings will be called. - `if-else-statements`: using a conditional statement. + +## Analyzer + +This exercise could benefit from the following rules in the [analyzer]: + +- `essential`: If the student did not use the `null` expression in the `print` method, instruct the student to do so. +- `informative`: If the solution uses `String.format`, instruct the student to use simple string concatenation instead. + Explain that `String.format` is significantly slower than concatenating strings and should be used in more complex scenarios. + +If the solution does not receive any of the above feedback, it must be exemplar. +Leave a `celebratory` comment to celebrate the success! + +[analyzer]: https://github.com/exercism/java-analyzer From e7f3052e683eda3914e7151f829f65ec1b2fcb16 Mon Sep 17 00:00:00 2001 From: manumafe98 Date: Sat, 30 Mar 2024 21:19:00 -0300 Subject: [PATCH 2/4] Adding another actionable comment when students use optionals --- exercises/concept/tim-from-marketing/.meta/design.md | 1 + 1 file changed, 1 insertion(+) diff --git a/exercises/concept/tim-from-marketing/.meta/design.md b/exercises/concept/tim-from-marketing/.meta/design.md index 4bd63438e..d387f77f2 100644 --- a/exercises/concept/tim-from-marketing/.meta/design.md +++ b/exercises/concept/tim-from-marketing/.meta/design.md @@ -24,6 +24,7 @@ This exercise could benefit from the following rules in the [analyzer]: - `essential`: If the student did not use the `null` expression in the `print` method, instruct the student to do so. +- `actionable`: If the solution uses `Optionals` to solve the exercise, encourage the student to try solving it differently. - `informative`: If the solution uses `String.format`, instruct the student to use simple string concatenation instead. Explain that `String.format` is significantly slower than concatenating strings and should be used in more complex scenarios. From 3c839f71084f23b459fa8d978e72870016aa02eb Mon Sep 17 00:00:00 2001 From: Manuel Maxera <95315128+manumafe98@users.noreply.github.com> Date: Sun, 31 Mar 2024 14:35:16 -0300 Subject: [PATCH 3/4] Update exercises/concept/tim-from-marketing/.meta/design.md Co-authored-by: Sander Ploegsma --- exercises/concept/tim-from-marketing/.meta/design.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/concept/tim-from-marketing/.meta/design.md b/exercises/concept/tim-from-marketing/.meta/design.md index d387f77f2..b62a71fba 100644 --- a/exercises/concept/tim-from-marketing/.meta/design.md +++ b/exercises/concept/tim-from-marketing/.meta/design.md @@ -24,7 +24,7 @@ This exercise could benefit from the following rules in the [analyzer]: - `essential`: If the student did not use the `null` expression in the `print` method, instruct the student to do so. -- `actionable`: If the solution uses `Optionals` to solve the exercise, encourage the student to try solving it differently. +- `actionable`: If the solution uses `Optionals` to solve the exercise, encourage the student to try solving it using `null` instead. - `informative`: If the solution uses `String.format`, instruct the student to use simple string concatenation instead. Explain that `String.format` is significantly slower than concatenating strings and should be used in more complex scenarios. From e310e847850025f5d489a216fe82a5bafed7aee2 Mon Sep 17 00:00:00 2001 From: manumafe98 Date: Sun, 31 Mar 2024 14:36:12 -0300 Subject: [PATCH 4/4] Removing essential comment --- exercises/concept/tim-from-marketing/.meta/design.md | 1 - 1 file changed, 1 deletion(-) diff --git a/exercises/concept/tim-from-marketing/.meta/design.md b/exercises/concept/tim-from-marketing/.meta/design.md index d387f77f2..af90b5dbe 100644 --- a/exercises/concept/tim-from-marketing/.meta/design.md +++ b/exercises/concept/tim-from-marketing/.meta/design.md @@ -23,7 +23,6 @@ This exercise could benefit from the following rules in the [analyzer]: -- `essential`: If the student did not use the `null` expression in the `print` method, instruct the student to do so. - `actionable`: If the solution uses `Optionals` to solve the exercise, encourage the student to try solving it differently. - `informative`: If the solution uses `String.format`, instruct the student to use simple string concatenation instead. Explain that `String.format` is significantly slower than concatenating strings and should be used in more complex scenarios.