Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to download album with too many artists #358

Open
1 task done
fstaffa opened this issue Feb 8, 2025 · 0 comments
Open
1 task done

Unable to download album with too many artists #358

fstaffa opened this issue Feb 8, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@fstaffa
Copy link

fstaffa commented Feb 8, 2025

You must use the search before you create an issue!

  • I did use the search, I promise!

What happened?

I tried downlading an album with many artists and it failed with OSError: [Errno 36] File name too long . This is name of album folder which it tried to generate using format_album='Albums/{album_artist} - {album_title}{album_explicit} [{album_year}] [tidal-{album_id}]/{track_volume_num_optional}{album_track_num}. {artist_name} - {track_title}{album_explicit}' was

Johann Sebastian Bach, Pyotr Ilyich Tchaikovsky, Gioachino Rossini, Felix Mendelssohn, Georges Bizet, Nikolai Rimsky-Korsakov, Giuseppe Verdi, Georg Friedrich Haendel, Classical Music 50 of the Best, Gabriel Fauré, Pietro Mascagni, John Williams, Adolphe - Рождественская музыка [2019] [tidal-123778216] which has 303 characters. Even using just the {album_artist} -{album_title} was 277 characters. I run zfs which has limit of 1023 for file length, but I suspect that python has lower limit.

There is a workaround when downloading specific album (update config just for it) but does not work when downloading favorite albums or artist.

The solution I was thinking about is to allow passing max length to format, e.g. say format_album='Albums/{album_artist:100} - {album_title}{album_explicit} [{album_year}] [tidal-{album_id}]/{track_volume_num_optional}{album_track_num}. {artist_name} - {track_title}{album_explicit}' where :100 would mean max length

Good workaround would be to skip such albums, log them and continue with following ones

Version App

v0.24.6

What operating system do you use?

Linux

Version OS

NixOS 25.5

Relevant log output

OSError: [Errno 36] File name too long: '/home/mathematician314/download/Albums/Johann Sebastian Bach, Pyotr Ilyich Tchaikovsky, Gioachino Rossini, Felix Mendelssohn, Georges Bizet, Nikolai
Rimsky-Korsakov, Giuseppe Verdi, Georg Friedrich Haendel, Classical Music 50 of the Best, Gabriel Fauré, Pietro Mascagni, John Williams, Adolphe - Рождественская музыка [2019] [tidal-123778216]'

Your settings

{
    "skip_existing": true,
    "lyrics_embed": false,
    "lyrics_file": false,
    "video_download": true,
    "download_delay": true,
    "download_base_path": "~/download",
    "quality_audio": "HI_RES_LOSSLESS",
    "quality_video": "480",
    "format_album": "Albums/{album_artist} - {album_title}{album_explicit} [{album_year}] [tidal-{album_id}]/{track_volume_num_optional}{album_track_num}. {artist_name} - {track_title}{album_explicit}",
    "format_playlist": "Playlists/{playlist_name}/{artist_name} - {track_title}",
    "format_mix": "Mix/{mix_name}/{artist_name} - {track_title}",
    "format_track": "Tracks/{artist_name} - {track_title}{track_explicit}",
    "format_video": "Videos/{artist_name} - {track_title}{track_explicit}",
    "video_convert_mp4": true,
    "path_binary_ffmpeg": "/nix/store/cmmpljxjw31bl8498is1kqfi9h33a9v6-ffmpeg-7.1-bin/bin/ffmpeg",
    "metadata_cover_dimension": "320",
    "metadata_cover_embed": true,
    "cover_album_file": true,
    "extract_flac": true,
    "downloads_simultaneous_per_track_max": 3,
    "download_delay_sec_min": 1.0,
    "download_delay_sec_max": 2.0,
    "album_track_num_pad_min": 1,
    "downloads_concurrent_max": 1,
    "symlink_to_track": false,
    "playlist_create": false
}
@fstaffa fstaffa added the bug Something isn't working label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant