diff --git a/README.md b/README.md index eed246e4..2aeded84 100644 --- a/README.md +++ b/README.md @@ -41,7 +41,8 @@ The plugin inherits all compiler options and file lists from your `tsconfig.json * `noEmitHelpers`: false * `importHelpers`: true * `noResolve`: false -* `noEmit`: false +* `noEmit`: false (Rollup controls emit) +* `noEmitOnError`: false (Rollup controls emit. See [#254](https://github.com/ezolenko/rollup-plugin-typescript2/issues/254) and the `abortOnError` plugin option below) * `inlineSourceMap`: false (see [#71](https://github.com/ezolenko/rollup-plugin-typescript2/issues/71)) * `outDir`: `./placeholder` in cache root, see [#83](https://github.com/ezolenko/rollup-plugin-typescript2/issues/83) and [Microsoft/TypeScript#24715](https://github.com/Microsoft/TypeScript/issues/24715) * `declarationDir`: Rollup's `output.file` or `output.dir` (*only if `useTsconfigDeclarationDir` is false in the plugin options*) diff --git a/__tests__/get-options-overrides.spec.ts b/__tests__/get-options-overrides.spec.ts index 4960d904..ec2c6725 100644 --- a/__tests__/get-options-overrides.spec.ts +++ b/__tests__/get-options-overrides.spec.ts @@ -49,6 +49,7 @@ const forcedOptions: ts.CompilerOptions = { inlineSourceMap: false, moduleResolution: ts.ModuleResolutionKind.NodeJs, noEmit: false, + noEmitOnError: false, noEmitHelpers: false, noResolve: false, outDir: `${cacheDir}/placeholder`, diff --git a/src/get-options-overrides.ts b/src/get-options-overrides.ts index 86617617..693d49a2 100644 --- a/src/get-options-overrides.ts +++ b/src/get-options-overrides.ts @@ -12,6 +12,7 @@ export function getOptionsOverrides({ useTsconfigDeclarationDir, cacheRoot }: IO importHelpers: true, noResolve: false, noEmit: false, + noEmitOnError: false, inlineSourceMap: false, outDir: normalize(`${cacheRoot}/placeholder`), // need an outdir that is different from source or tsconfig parsing trips up. https://github.com/Microsoft/TypeScript/issues/24715 moduleResolution: tsModule.ModuleResolutionKind.NodeJs,