Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control commands don't parse correctly #79

Open
oscgonfer opened this issue Nov 20, 2024 · 0 comments
Open

Control commands don't parse correctly #79

oscgonfer opened this issue Nov 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@oscgonfer
Copy link
Contributor

Control commands for sensors don't parse correctly when there are more than two words on the command:

This works:

SCK > control sen5x
SEN5X PM 1.0: 
Available commands:
* debug: [0-1] Sets debug messages
* doclean: Starts a cleaning
* lastClean
* info

Or:

SCK > control sen5x debug
SEN5X PM 1.0: debug
Debug: false

But this doesn't:

control sen5x debug 1
SEN5X PM 1.0: 1
Sensor not recognized, or no control interface available for this sensor

Culprit is the function sensorNameEndsIn, that doesn't work for more than two commands, and seems to return the wrong index for the command to be cleaned at.

IMPORTANT, when testing, it's important to check #60

@oscgonfer oscgonfer added the bug Something isn't working label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant