Set also MaxMetaspace on Java 8

[rhuss]

If running under Java 8, the Metaspace should be limited, too in --> https://github.com/fabric8io-images/run-java-sh/blob/master/fish-pepper/run-java-sh/fp-files/java-default-options#L46

[rhuss]

@astefanutti wdyt about limiting the MaxMetaspace, too ?

[astefanutti]

Yes, that makes sense. Let me try working something out.

As we go from sizing from one region (the heap), to multiple regions (metaspace, and JIT code maybe), it becomes tricker to heuristically size them generally. At least each one can be bound to max memory minus heap size.

[derkoe]

Don't forget direct memory used by NIO buffers: -XX:MaxDirectMemorySize. See https://docs.oracle.com/cd/E15289_01/doc.40/e15062/optionxx.htm#BABGCFFB

[rhuss]

Thanks ! wonder how this could be combined with the -xmx heap settings so that the combined value (+ all the other non-heap memory) doesn't exceed the given constraints.

I think we can't give a good default value and as this limit is unbounded by default anyway, I think also that its fair to require that the users have to specify this limit on their own when they require it.