Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing svg shadow description for pathGroups (toSVG) #2363

Closed
MohamedElamry opened this issue Jul 27, 2015 · 4 comments · Fixed by #2364
Closed

missing svg shadow description for pathGroups (toSVG) #2363

MohamedElamry opened this issue Jul 27, 2015 · 4 comments · Fixed by #2364
Labels

Comments

@MohamedElamry
Copy link

  1. Load some svg files into canvas
  2. Apply some effects like shadow on them.
  3. Export to svg using canvas.toSVG()
  4. Open the resulted svg in browser or editor.
    Result:
  5. Objects without shadows are visible.
  6. Objects with shadow disappear even though they exist in svg source.

see http://jsfiddle.net/Rafie/29n4zo54/

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@asturur asturur added the bug label Jul 27, 2015
@asturur
Copy link
Member

asturur commented Jul 27, 2015

it looks like you are the first one that put a shadow on a pathgroup.
Effectively the pathgroup get exported with a filter = "shadow" prodperty, but that filter does not get created.
A bug.

@MohamedElamry
Copy link
Author

I found the same happen if I apply shadow to image objects too.

@MohamedElamry
Copy link
Author

I checked the code and found that _createBaseSVGMarkup() is not called inside toSVG() in either path-group nor image classes.

I'm working on a pull request now but not sure if my changes will have side effects or not.

@asturur
Copy link
Member

asturur commented Jul 27, 2015

Do not worry, it is missing for group, path-group and image.
I'm gonna do that now.

@asturur asturur changed the title If object is loaded from .svg and set shadow that object doesn't appear in the exported svg missing svg shadow description for pathGroups (toSVG) Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants