Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text shadow multi level casting #2807

Closed
asturur opened this issue Feb 25, 2016 · 4 comments · Fixed by #2827
Closed

Text shadow multi level casting #2807

asturur opened this issue Feb 25, 2016 · 4 comments · Fixed by #2827
Labels

Comments

@asturur
Copy link
Member

asturur commented Feb 25, 2016

Version

1.6.0 latest

Test Case

image

Steps to reproduce

go on kitchensink, add a text and add background color to both text and itext. Shadowify them.

Actual Behavior

shadow of text drops over text background that also drop shadow on object background.

Expected Behavior

is this what we really want? 3 leves of shadows?

@asturur
Copy link
Member Author

asturur commented Feb 25, 2016

This is a proposed alternative solution.

image

for Itext:
image

@asturur asturur changed the title Text shadow Text shadow multi level casting Feb 25, 2016
@asturur
Copy link
Member Author

asturur commented Feb 25, 2016

@kangax if interested in this change, a demo pr is already available.

@kangax
Copy link
Member

kangax commented Feb 28, 2016

2nd version definitely looks better! Good stuff :)

@asturur
Copy link
Member Author

asturur commented Mar 11, 2016

needs svg rebase and close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants